----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74897/#review226227 -----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js Lines 522 (patched) <https://reviews.apache.org/r/74897/#comment314473> Instead of looking for PolicyCondition.type == "_expression", consider checking for one of the following in RangerPolicyConditionDef: - evaluator == "org.apache.ranger.plugin.conditionevaluator.RangerScriptConditionEvaluator" - evaluatorOptions["ui.isMultiline"] == "true" - Madhan Neethiraj On Feb. 20, 2024, 11:52 a.m., Himanshu Maurya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74897/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2024, 11:52 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, > Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > While using attributes with default values introduced in RANGER-3997 like > GET_USER_ATTR('state', 'null') in policy condition. > It is observed that ranger is splitting condition string in to parts > separated by comma of the parameters passed to GET_USER_ATTR(), due to this > it is not taking default value and conditions are converted to invalid > strings. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 5f6d9ac01 > > > Diff: https://reviews.apache.org/r/74897/diff/1/ > > > Testing > ------- > > Done the required code changes and installed ranger. > Validated the policy conditions with default comma separated parameters > passed with attributes. > > > Thanks, > > Himanshu Maurya > >
