----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74887/#review226266 -----------------------------------------------------------
Ship it! Ship It! - Brijesh Bhalala On Feb. 28, 2024, 1:44 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74887/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2024, 1:44 p.m.) > > > Review request for ranger, Brijesh Bhalala and Dhaval Rajpara. > > > Bugs: RANGER-4717 > https://issues.apache.org/jira/browse/RANGER-4717 > > > Repository: ranger > > > Description > ------- > > From server side the api used in Audit Login Sessions Tab - > "/service/xusers/authSessions" has added a validation to requestIP api query > parameter. > > When user enter text value a 'page not found' is shown. Need to skip showing > 'page not found' page for such scenario and show the server-side response as > an alert on Login Session Tab. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > 8e12ec6541d6e4b7195f8f24b42f05d9ab9236bd > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx > 37aa0e01e1722fd7e2ff7cbe21acb1058ffeb522 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx > d6f8b433d56f6c75f21f2216d626563bfeb684da > > > Diff: https://reviews.apache.org/r/74887/diff/2/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > Verified the 'page not found' page is not shown on Audit > Login Sessions Tab > when entered wrong value to requestIP api query parameter. The error is shown > as an alert on UI. > > > Successful completion of build command : > mvn clean compile package > > > Thanks, > > Mugdha Varadkar > >
