----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74949/#review226376 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultService.java Line 36 (original), 36 (patched) <https://reviews.apache.org/r/74949/#comment314600> Consider using a constant for the error message, to avoid multiple hardcoded instances across modules. - Madhan Neethiraj On April 3, 2024, 4:40 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74949/ > ----------------------------------------------------------- > > (Updated April 3, 2024, 4:40 a.m.) > > > Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika > Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4763 > https://issues.apache.org/jira/browse/RANGER-4763 > > > Repository: ranger > > > Description > ------- > > Send user-friendly message if Test connection is not implemented for a > service definition > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultService.java > c89b55757 > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java > 7e071ba0e > security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java > d6fc01176 > > > Diff: https://reviews.apache.org/r/74949/diff/2/ > > > Testing > ------- > > Validated "Test Connection" when the service definition does not have > implClass, it gives the below response in this case. > { > "statusCode": 1, > "msgDesc": "Configuration validation is not implemented for hbase", > "messageList": [ > { > "message": "Configuration validation is not implemented for hbase" > } > ] > } > > > Thanks, > > Anand Nadar > >
