kumaab commented on code in PR #337:
URL: https://github.com/apache/ranger/pull/337#discussion_r1677182165
##########
security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java:
##########
@@ -783,31 +783,49 @@ public void testAuditFileQueueSpoolORCRollover(){
String fileSpoolPrefix = filequeuePrefix + ".filespool";
props.put(fileSpoolPrefix+".dir",spoolFolderName);
props.put(fileSpoolPrefix+".buffer.size",""+100000000000000L);
- props.put(fileSpoolPrefix+".file.rollover.sec",""+300);
+ props.put(fileSpoolPrefix+".file.rollover.sec",""+5);
AuditProviderFactory factory = new AuditProviderFactory();
factory.init(props, appType);
AuditHandler queue = factory.getAuditProvider();
- for (int i = 0; i < messageToSend; i++) {
+ for (int i = 0; i < preRolloverMessagesCount; i++) {
queue.log(createEvent());
try {
- Thread.sleep(5);
+ Thread.sleep(10);
} catch (InterruptedException e) {
System.out.println(e);
Review Comment:
Please use logger.error
##########
security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java:
##########
@@ -783,31 +783,49 @@ public void testAuditFileQueueSpoolORCRollover(){
String fileSpoolPrefix = filequeuePrefix + ".filespool";
props.put(fileSpoolPrefix+".dir",spoolFolderName);
props.put(fileSpoolPrefix+".buffer.size",""+100000000000000L);
- props.put(fileSpoolPrefix+".file.rollover.sec",""+300);
+ props.put(fileSpoolPrefix+".file.rollover.sec",""+5);
AuditProviderFactory factory = new AuditProviderFactory();
factory.init(props, appType);
AuditHandler queue = factory.getAuditProvider();
- for (int i = 0; i < messageToSend; i++) {
+ for (int i = 0; i < preRolloverMessagesCount; i++) {
queue.log(createEvent());
try {
- Thread.sleep(5);
+ Thread.sleep(10);
} catch (InterruptedException e) {
System.out.println(e);
}
}
+ //wait for rollover to happen
try {
- Thread.sleep(40000);
+ Thread.sleep(10000);
} catch (InterruptedException e) {
System.out.println(e);
}
+ //send some more logs
+ for (int i = 0; i < postRolloverMessagesCount; i++) {
+ queue.log(createEvent());
+ try {
+ Thread.sleep(10);
+ } catch (InterruptedException e) {
+ System.out.println(e);
Review Comment:
Please use logger.error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
