----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75101/ -----------------------------------------------------------
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, Vishal Bhavsar, and Velmurugan Periasamy. Bugs: RANGER-4864 https://issues.apache.org/jira/browse/RANGER-4864 Repository: ranger Description ------- Upon performing Policy Import some of the corresponding Audit Admin logs are improper. 1)While importing if we check Override Policy checkbox then it would delete the existing policy and create new policy for the specific resource. Observed for this action in Audit Admin tab we are seeing "Unknown" value in Action column. Also upon clicking the log modal opens which does not show any data. 2)Import End Audit log should be the Last log seen in Audit Admin tab, however here we are seeing one policy creation log after the Import log. 3)Upon clicking on Import End log, modal opens which shows its details, here the Export time format is wrong. Steps to repro: In Service Manager page , export the policies for all the services by clicking on top right Export button. Now import the policy by clicking on top right Import button, select the above exported policy json file, check the "Override Policy" box. Now click on Import. Once import done check the logs in Audit Admin tab. Diffs ----- security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 3479d65d7 security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java ee1eb371e security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java 3b9a83a95 security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx 4f974097f Diff: https://reviews.apache.org/r/75101/diff/1/ Testing ------- I have tested and verified the following issues: 1). When "Override Policy" is checked during import, the Action column in the Audit Admin tab now displays the correct action, and the log modal shows the appropriate data. 2). The "Import End" log is now the last entry in the Audit Admin tab, with no policy creation log appearing after it. 3). The export time format in the "Import End" log modal is now correct. Thanks, Rakesh Gupta