fateh288 commented on code in PR #369:
URL: https://github.com/apache/ranger/pull/369#discussion_r1697344348
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -86,6 +87,7 @@ public RangerBasePlugin(String serviceType, String
serviceName, String appId) {
}
public RangerBasePlugin(RangerPluginConfig pluginConfig) {
+ this.pluginAnalytics = new RangerPluginAnalytics();
Review Comment:
I see just 4 constructors - line 511, 515, 519 and 565 - in
RangerBasePlugin.java
@vyommani Can you point to the other 2 constructors you are seeing ?
Constructor 1: Always calls constructor 3
Constructor 2: Always calls constructor 4
So I added pluginAnalytics function calls only for constructor 3 and
constructor 4.
Adding it to all the 4 constructors would result in double counting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
