> On Aug. 12, 2024, 9:14 a.m., Vyom Tiwari wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > > Lines 1367 (patched) > > <https://reviews.apache.org/r/75151/diff/5/?file=2292658#file2292658line1463> > > > > Is there an noticeable overhead of copying filter to private > > ‘this.filter’ ?. If not then I will recommends copy of the parameter as > > follows > > > > this.filter = filter == null ? Collections.emptySet() : new > > HashSet<>(filter);
Any specific reason to consider copying the given filter collection? When large number of evaluators are involved, copying contributs to significant overhead. Hence copying is avoided where possible. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75151/#review226814 ----------------------------------------------------------- On Aug. 8, 2024, 7:46 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75151/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2024, 7:46 p.m.) > > > Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, > Fateh Singh, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, Velmurugan > Periasamy, and Vyom Tiwari. > > > Bugs: RANGER-4893 > https://issues.apache.org/jira/browse/RANGER-4893 > > > Repository: ranger > > > Description > ------- > > - enhanced RangerResourceTrie to support handlers for matches found during > traversal > - custom handlers are used to get count of matchers, collect all matchers, > collect matchers within a given subset > - above enhancements are used to efficiently retrieve evaluators for > multi-level resources - like database/table/column > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > 773a02609 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDataShareEvaluator.java > 95f06209d > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java > 2ba8135b1 > > > Diff: https://reviews.apache.org/r/75151/diff/5/ > > > Testing > ------- > > - verified build with unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
