----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75179/#review226861 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Aug. 16, 2024, 4:09 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75179/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2024, 4:09 p.m.) > > > Review request for ranger, Abhishek Kumar, Anand Nadar, Asit Vadhavkar, > Fateh Singh, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Subhrat Chaudhary. > > > Bugs: RANGER-4908 > https://issues.apache.org/jira/browse/RANGER-4908 > > > Repository: ranger > > > Description > ------- > > - updated RangerAdminRESTClient to use session cookie for all API calls to > Ranger; earlier this was used only for policy/tag/role download API calls > - updated RangerAdminRESTClient to use a single cookie for all APIs, > replacing use of 3 different cookies: policyDownloadSessionId, > tagDownloadSessionId, roleDownloadSessionId > - updated RangerRESTClient to use separate client when session cookie is > used; this eliminates the need to clear filters, which can fail when used > simultaneously from multiple threads > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 70bd818dd > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > 621d07614 > > > Diff: https://reviews.apache.org/r/75179/diff/1/ > > > Testing > ------- > > - verified build with unit tests completes successfully > - verified that all calls from the plugin - download/grant/revoke use session > cookie to authenticate with Ranger (when configured) > > > Thanks, > > Madhan Neethiraj > >