----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75210/ -----------------------------------------------------------
(Updated Sept. 27, 2024, 1:04 p.m.) Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. Changes ------- Addressed review comments. Bugs: RANGER-4809 https://issues.apache.org/jira/browse/RANGER-4809 Repository: ranger Description ------- With updates in RANGER-4803, Ranger will store admin audit records in x_trx_log_v2 table. Prior to this, x_trx_log table was used to store these records. To make earlier admin audits available to updated Ranger, existing entries in x_trx_log should be migrated to x_trx_log_v2 table. Diffs (updated) ----- embeddedwebserver/scripts/ranger-admin-transaction-log-migrate.sh PRE-CREATION security-admin/src/main/java/org/apache/ranger/patch/cliutil/TrxLogV2MigrationUtil.java PRE-CREATION security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1672c148e Diff: https://reviews.apache.org/r/75210/diff/3/ Changes: https://reviews.apache.org/r/75210/diff/2-3/ Testing (updated) ------- The environment variables RANGER_ADMIN_HOME, RANGER_ADMIN_CONF and RANGER_ADMIN_LOG_DIR must be set correctly for the migration of transaction logs to proceed. 1)Verified that all transaction from the x_trx_log table has been migrated to the x_trx_log_v2 table when the default config value is -1. 2)Verified that data migration from the x_trx_log table to the x_trx_log_v2 table follows the config "ranger.admin.migrate.transaction_records.retention.days", ensuring that only records within the specified number of days are migrated. 3)Verified that multiple records with the same trx_id from the x_trx_log table are merged into a single transaction record in the x_trx_log_v2 table. 4)Verified that the x_trx_log_v2.change_info column is populated with the combined contents of the attr_name, prev_val, and new_val columns from multiple x_trx_log rows. 5)Verified that new transactions are being correctly stored in the x_trx_log_v2 table. Thanks, Rakesh Gupta