-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75213/
-----------------------------------------------------------
(Updated Oct. 6, 2024, 11:43 p.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Radhika Kundam.
Changes
-------
Review comments addressed
Bugs: RANGER-4937
https://issues.apache.org/jira/browse/RANGER-4937
Repository: ranger
Description
-------
RANGER-4937: Add a new GDS resource API for adding new resources to a new or
existing DataShare and add it to the DataSet
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 0b3d91001
Diff: https://reviews.apache.org/r/75213/diff/4/
Changes: https://reviews.apache.org/r/75213/diff/3-4/
Testing
-------
Add a new GDS resource API for adding new resources to a new or existing
DataShare and add it to the DataSet
- add a resource to a dataset using existing API "POST service/gds/resource",
with following enhancements:
Testing done with local vm:
- Create a DataSet with "POST service/gds/dataset".
- Call the enhanced API "/dataset/{id}/resources/{serviceName}" as following.
curl -ikv -u admin:Admin123 -X POST -H "Content-Type: application/json"
'http://localhost:6080/service/gds/dataset/30/resources/cm_hive' -d '[ {
"createdBy": "Admin", "isEnabled": "true", "version": 1, "dataShareId":"-1",
"resource":{ "database":{ "values":["test_db"] }, "table":{
"values":["sal1","sal2","sal4"] }, "column": { "values": [ "id" ],
"isExcludes": false, "isRecursive": false } }, "name":"test-resource-17",
"accessTypes":["all"] }, { "createdBy": "Admin", "isEnabled": "true",
"version": 1, "dataShareId":"-1", "resource":{ "database":{
"values":["default"] }, "table":{
"values":["sal2","emp","tb_1","sal1","sal3","tb_2"] }, "column": { "values": [
"*" ], "isExcludes": false, "isRecursive": false } },
"name":"test-resource-18", "accessTypes":["all"] }]'
curl -ikv -u admin:Admin123 -X POST -H "Content-Type: application/json"
'http://localhost:6080/service/gds/dataset/30/resources/cm_hive' -d '[ {
"createdBy": "Admin", "isEnabled": "true", "version": 1, "dataShareId":"-1",
"resource":{ "database":{ "values":["test_db3"] }, "table":{
"values":["sal12","sal22","sal42"] }, "column": { "values": [ "id" ],
"isExcludes": false, "isRecursive": false } }, "name":"test-resource-172",
"accessTypes":["all"] }]'
Thanks,
Ramesh Mani
