----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75232/ -----------------------------------------------------------
Review request for ranger, Abhishek Kumar, Anand Nadar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Pradeep Agrawal, Radhika Kundam, Ramesh Mani, and Sailaja Polavarapu. Bugs: RANGER-4956 https://issues.apache.org/jira/browse/RANGER-4956 Repository: ranger Description ------- - dedupTags() on a ServiceTag instance can result in infinite loop when its cachedTags is already populated (by an earlier call or via a copy constructor), as it tries to replace a tag with itself. Updated to avoid such replacement. Diffs ----- agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java cc2ebe53a agents-common/src/test/java/org/apache/ranger/plugin/util/TestServiceTags.java PRE-CREATION Diff: https://reviews.apache.org/r/75232/diff/1/ Testing ------- - added unit tests to verify dedupTags() - verified that all unit tests pass Thanks, Madhan Neethiraj