----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75230/#review226975 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/entity/XXGdsDataset.java Line 118 (original), 151 (patched) <https://reviews.apache.org/r/75230/#comment315259> hashCode() should be updated to include new attributes. security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java Lines 73 (patched) <https://reviews.apache.org/r/75230/#comment315260> Shouldn't this be a PARTIAL search i.e. SearchField.SEARCH_TYPE.PARTIAL, since multiple entries could be present for labels/keywords and search would specify a single value? - Madhan Neethiraj On Oct. 16, 2024, 8:04 p.m., Radhika Kundam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75230/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2024, 8:04 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-4933 > https://issues.apache.org/jira/browse/RANGER-4933 > > > Repository: ranger > > > Description > ------- > > Ranger API to Summary View of DataShares in a GDS > Summary should have the following details. > > DataShare > Number of Assets on the DataShare. > Created by and when details. > End of Support Date > Tags (Labels) > Keywords > Number of external user which this DataShare is shared. > > Mapping of Requested Data to Response Properties: > ------------------------------------------------ > DataShare: "dataShares" > Number of Assets on the DataShare: "totalResourceCount" > Created by and when details: "createdBy" and "createTime" > End of Support Date: "validitySchedule" > Tags: "labels" > Keywords: "keywords" > Number of external user which this DataShare is shared: "principalsCount" > > Attached the document with Datashare summary API request and response details. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java > d582e420f > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 0da5f2aaf > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 6c48c49f4 > > security-admin/db/mysql/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql > PRE-CREATION > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 551660ab4 > > security-admin/db/oracle/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql > PRE-CREATION > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 34a092e89 > > security-admin/db/postgres/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql > PRE-CREATION > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 792fffd8d > > security-admin/db/sqlanywhere/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql > PRE-CREATION > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > eccf7f46f > > security-admin/db/sqlserver/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 9bb946996 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 42eb7dfaa > security-admin/src/main/java/org/apache/ranger/entity/XXGdsDataset.java > 6fdc5be95 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > 659c07f16 > > > Diff: https://reviews.apache.org/r/75230/diff/2/ > > > Testing > ------- > > Tested manually. > > > File Attachments > ---------------- > > DataShare summary view API details > > https://reviews.apache.org/media/uploaded/files/2024/10/10/cafc429e-2559-4c93-9506-10128682cfa5__SummaryView_Datashares_in_GDS_API_request_response.json > DataShare summary view API details > > https://reviews.apache.org/media/uploaded/files/2024/10/10/b94bad0f-c98a-4a86-a3f6-4fd558c0b24c__SummaryView_Datashares_in_GDS_API_request_response.json > > > Thanks, > > Radhika Kundam > >
