> On Oct. 23, 2024, midnight, Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/CachedResourceEvaluators.java > > Line 95 (original), 95 (patched) > > <https://reviews.apache.org/r/75227/diff/2-3/?file=2293869#file2293869line95> > > > > To avoid potential NPE, consider replacing: > > > > > > request.getResourceMatchingScope().equals(RangerAccessRequest.ResourceMatchingScope.SELF_OR_DESCENDANTS)) > > > > with: > > > > > > RangerAccessRequest.ResourceMatchingScope.SELF_OR_DESCENDANTS.equals(request.getResourceMatchingScope())
This should not an issue as the request's (specifically RangerAccessRequestImpl object's) resourceMatchingScope member variable is always null - default value is RangerAccessRequest.ResourceMatchingScope.SELF. In any case, this comment is addressed now. - Abhay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75227/#review226991 ----------------------------------------------------------- On Oct. 23, 2024, 5:43 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75227/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2024, 5:43 p.m.) > > > Review request for ranger, madhan, Madhan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-4967 > https://issues.apache.org/jira/browse/RANGER-4967 > > > Repository: ranger > > > Description > ------- > > RangerTagEnricher is optimized to search Trie objects for reduced scope. This > functionality should be usable by other modules that may need to deal with > the scale/performance issues similar to ones encountered when searching large > number of tags. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 63ed47ded > > agents-common/src/main/java/org/apache/ranger/plugin/util/CachedResourceEvaluators.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/75227/diff/4/ > > > Testing > ------- > > Passed all unit tests cleanly. > > > Thanks, > > Abhay Kulkarni > >
