-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75252/#review227029
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
Lines 891 (patched)
<https://reviews.apache.org/r/75252/#comment315297>

    RangerGdsGrant seems to be redundant as there is RangerGrant Class defined. 
Please review



security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java
Lines 262 (patched)
<https://reviews.apache.org/r/75252/#comment315298>

    move line 262, 263 to line 256


- Ramesh Mani


On Nov. 6, 2024, 12:06 a.m., Radhika Kundam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75252/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2024, 12:06 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-4960
>     https://issues.apache.org/jira/browse/RANGER-4960
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This Grant API introduces functionality to grant or revoke specific 
> permissions on datasets to external users, groups, or roles. It includes 
> support for defining access validity based on policy item conditions. 
> 
> Key features include:
> 1. Permission Management: Enables granting and revoking access to datasets 
> for designated users, groups, or roles.
> 2. Policy-Based Validity: Allows setting validity periods and conditions 
> within policy items, defining the scope and duration of access for each user, 
> group, or role.
> 
> This API enhancement provides flexibility in managing dataset permissions, 
> improving security and control over data access.
> 
> Attached file for Grant API UseCases.
> 
> Detailed information about Grant API request and response attached to Jira.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java 
> 68216fd45 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGrant.java 
> PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyHeader.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> a6c6746b3 
>   security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java c66429834 
>   
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java
>  acfce5f0a 
>   security-admin/src/test/java/org/apache/ranger/rest/TestGdsREST.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/75252/diff/2/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> File Attachments
> ----------------
> 
> Grant API UseCases
>   
> https://reviews.apache.org/media/uploaded/files/2024/11/06/db61e292-0942-428b-b6d9-c771336dfca0__Grant_API_UseCases.pdf
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>

Reply via email to