> On Nov. 7, 2024, 7:55 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDatasetEvaluator.java > > Line 125 (original), 139 (patched) > > <https://reviews.apache.org/r/75260/diff/1/?file=2294062#file2294062line139> > > > > Will this result in a project getting added multiple times to > > projectsToEval ?
The collection is actually a set, so it will not contain duplicates. I update the patch to replace datatype Collection to Set. > On Nov. 7, 2024, 7:55 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > > Line 421 (original), 422 (patched) > > <https://reviews.apache.org/r/75260/diff/1/?file=2294063#file2294063line423> > > > > The naming of variables is confusing in this method. > > > > resources -> evaluators ? > > resource -> evaluator ? > > dataShare -> dataShareEvaluator ? There are many types of evaluators used here: GdsSharedResourceEvaluator, GdsDataShareEvaluator, GdsDatasetEvaluator, GdsProjectEvaluator, and more. Hence replaced use of generic term evaluator with resource/dataShare/dataset/project to make it easier to read. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75260/#review227039 ----------------------------------------------------------- On Nov. 6, 2024, 11:30 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75260/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2024, 11:30 p.m.) > > > Review request for ranger, Abhishek Kumar, Fateh Singh, Kishor > Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4985 > https://issues.apache.org/jira/browse/RANGER-4985 > > > Repository: ranger > > > Description > ------- > > - updated GdsAccessResult with 2 new fields: allowedByDatasets, > allowedByProjects > - updated GDS policy evaluation to populate the new fields > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > 402cbda68 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsAccessResult.java > b2158579f > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDataShareEvaluator.java > 98f8da493 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDatasetEvaluator.java > 9c37b6783 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > 972e8bf28 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsProjectEvaluator.java > 89324ddb4 > > agents-common/src/test/resources/policyengine/gds/test_gds_policy_engine_hive.json > a5e3636b3 > > > Diff: https://reviews.apache.org/r/75260/diff/1/ > > > Testing > ------- > > - updated tests to validate that GDS policy evaluation populates the new > fields introduced correctly > > > Thanks, > > Madhan Neethiraj > >
