-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75264/
-----------------------------------------------------------

Review request for ranger, Fateh Singh, madhan, Madhan Neethiraj, Pradeep 
Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4990
    https://issues.apache.org/jira/browse/RANGER-4990


Repository: ranger


Description
-------

Policies/tags are selected for processing based on how the they match the 
accessed resource. The logic for the selection of policies/tags depends on 

resourceMatchingScope specified in the access request, and
if the type of access desired is of type 'any'.
The logic for the selection is inconsistent and hard to reason about. 
Additionally, code referencing the resourceMatchingScope does not check for 
null-ness. This may cause NullPointerExceptions.


Diffs
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 c9ca7d822 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsSharedResourceEvaluator.java
 6e36c00cc 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
 006ceefc3 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java
 96610e2eb 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 621b65137 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/CachedResourceEvaluators.java
 ff2d04376 
  agents-common/src/test/resources/policyengine/test_policyengine_hive.json 
8e34aa174 
  
agents-common/src/test/resources/policyengine/test_policyengine_marker_access_types.json
 a18523b60 


Diff: https://reviews.apache.org/r/75264/diff/1/


Testing
-------

Compiled clean and passed all unit tests.


Thanks,

Abhay Kulkarni

Reply via email to