kumaab commented on code in PR #418: URL: https://github.com/apache/ranger/pull/418#discussion_r1861164846
########## knox-agent/pom.xml: ########## @@ -17,38 +17,88 @@ --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> - <artifactId>ranger-knox-plugin</artifactId> - <name>Knox Security Plugin</name> - <description>Knox Security Plugins</description> - <packaging>jar</packaging> - <properties> - <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> - <knox.jetty.version>9.4.51.v20230217</knox.jetty.version> - </properties> <parent> <groupId>org.apache.ranger</groupId> <artifactId>ranger</artifactId> <version>2.6.0-SNAPSHOT</version> <relativePath>..</relativePath> </parent> + <artifactId>ranger-knox-plugin</artifactId> + <packaging>jar</packaging> + <name>Knox Security Plugin</name> + <description>Knox Security Plugins</description> + <properties> + <knox.jetty.version>9.4.51.v20230217</knox.jetty.version> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + </properties> <dependencies> <dependency> - <groupId>org.apache.knox</groupId> - <artifactId>gateway-spi</artifactId> - <version>${knox.gateway.version}</version> + <groupId>com.fasterxml.jackson.core</groupId> + <artifactId>jackson-annotations</artifactId> + <version>${fasterxml.jackson.version}</version> + </dependency> + <dependency> + <groupId>com.fasterxml.jackson.core</groupId> + <artifactId>jackson-core</artifactId> + <version>${fasterxml.jackson.version}</version> + </dependency> + <dependency> + <groupId>com.google.code.gson</groupId> + <artifactId>gson</artifactId> + </dependency> + <dependency> + <groupId>com.google.protobuf</groupId> + <artifactId>protobuf-java</artifactId> + <version>${protobuf-java.version}</version> + </dependency> + <dependency> + <groupId>commons-collections</groupId> + <artifactId>commons-collections</artifactId> + <version>${commons.collections.version}</version> + </dependency> + <dependency> + <groupId>jakarta.ws.rs</groupId> + <artifactId>jakarta.ws.rs-api</artifactId> + <version>2.1.6</version> Review Comment: Jakarta apis will replace javax apis going forward, we can keep this in root pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org