----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75290/#review227094 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Nov. 28, 2024, 8:28 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75290/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2024, 8:28 p.m.) > > > Review request for ranger, Abhishek Kumar, Fateh Singh, Abhay Kulkarni, > Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vikas > Kumar. > > > Bugs: RANGER-5010 > https://issues.apache.org/jira/browse/RANGER-5010 > > > Repository: ranger > > > Description > ------- > > - start and end times specified for validity schedule are parsed into a Date > value using SimpleDataFormat. SimpleDataFormat parser adjusts the time for > the timzone set in the environment. However, request.accessTime has the value > in UTC for GMT. > - to fix the issue, updated validity schedule parser to use GMT as the > default timezone > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java > 31501c709 > > > Diff: https://reviews.apache.org/r/75290/diff/1/ > > > Testing > ------- > > - verified that unit tests pass with different values for environment > variable TZ (IST, GMT, PST, ART) > > > Thanks, > > Madhan Neethiraj > >
