mneethiraj commented on code in PR #431:
URL: https://github.com/apache/ranger/pull/431#discussion_r1876349311
##########
ranger-metrics/src/main/java/org/apache/ranger/metrics/sink/RangerMetricsJsonSink.java:
##########
@@ -66,8 +66,8 @@ record = new HashMap<> ();
}
} else {
if (LOG.isDebugEnabled()) {
- LOG.debug("=== RangerMetricsJsonSink:putMetrics():
skipping... "+ metricsRecord.context());
- }
+ LOG.debug("=== RangerMetricsJsonSink:putMetrics():
skipping... " + metricsRecord.context());
Review Comment:
Replace string concat with parameterized log message:
```
LOG.debug("=== RangerMetricsJsonSink:putMetrics(): skipping... {}",
metricsRecord.context());
```
With this, the surrounding `if (LOG.isDebugEnabled()) {` can be removed as
well. Please review and update other occurrences as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
