mneethiraj commented on code in PR #442:
URL: https://github.com/apache/ranger/pull/442#discussion_r1880962848
##########
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerLegacyConfigBuilder.java:
##########
@@ -19,227 +19,220 @@
package org.apache.ranger.authorization.hadoop.config;
-import java.io.File;
-import java.net.URL;
-import java.util.HashMap;
-import java.util.Map;
-
import org.apache.hadoop.conf.Configuration;
import org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.io.File;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.Map;
+
public class RangerLegacyConfigBuilder {
+ private static final Logger LOG =
LoggerFactory.getLogger(RangerLegacyConfigBuilder.class);
+
+ static String serviceType;
+ static String legacyResource;
+
+ private RangerLegacyConfigBuilder() {
+ // to block instantiation
+ }
+
+ public static Configuration getSecurityConfig(String serviceType) {
+ RangerLegacyConfigBuilder.legacyResource =
getPropertyName(RangerConfigConstants.XASECURE_SECURITY_FILE, serviceType);
+ RangerLegacyConfigBuilder.serviceType = serviceType;
+
+ Configuration ret = null;
Review Comment:
Removing initialization in line 46 will result in compilation error, since
ret will not assigned before referencing at line 60.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
