----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75311/#review227129 -----------------------------------------------------------
dev-support/ranger-docker/Dockerfile.ranger-oracle Lines 25 (patched) <https://reviews.apache.org/r/75311/#comment315402> Password can be passed from both docker-compose file, as well as arguments to docker build while building the image from Dockerfile itself. dev-support/ranger-docker/config/init_oracle.sh Lines 1 (patched) <https://reviews.apache.org/r/75311/#comment315405> may be we should keep all oracle related configs in one place, like dev-support/ranger-docker/config/oracle ? this will help to maintain scripts and config directories. dev-support/ranger-docker/docker-compose.ranger-oracle.yml Lines 1 (patched) <https://reviews.apache.org/r/75311/#comment315403> version: '3' is deprecated. dev-support/ranger-docker/docker-compose.ranger-oracle.yml Lines 7 (patched) <https://reviews.apache.org/r/75311/#comment315404> Oracle db password could be passed here. - Abhishek Kumar On Dec. 13, 2024, 10:51 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75311/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2024, 10:51 p.m.) > > > Review request for ranger, Abhishek Kumar, Don Bosco Durai, Dhaval Shah, > Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Mugdha > Varadkar, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja > Polavarapu. > > > Bugs: RANGER-5073 > https://issues.apache.org/jira/browse/RANGER-5073 > > > Repository: ranger > > > Description > ------- > > - updated docker setup scripts to support Oracle database > > > Diffs > ----- > > dev-support/ranger-docker/.env 3936c1fac > dev-support/ranger-docker/Dockerfile.ranger a0fd0fec7 > dev-support/ranger-docker/Dockerfile.ranger-hive dd326f854 > dev-support/ranger-docker/Dockerfile.ranger-kms c3431c5b1 > dev-support/ranger-docker/Dockerfile.ranger-oracle PRE-CREATION > dev-support/ranger-docker/README.md 231e91fbf > dev-support/ranger-docker/config/init_oracle.sh PRE-CREATION > dev-support/ranger-docker/docker-compose.ranger-oracle.yml PRE-CREATION > dev-support/ranger-docker/download-archives.sh 4b2736fb6 > dev-support/ranger-docker/scripts/hive-site-oracle.xml PRE-CREATION > dev-support/ranger-docker/scripts/ranger-admin-install-oracle.properties > PRE-CREATION > dev-support/ranger-docker/scripts/ranger-kms-install-oracle.properties > PRE-CREATION > pom.xml be162d010 > > > Diff: https://reviews.apache.org/r/75311/diff/1/ > > > Testing > ------- > > - successfully deployed Ranger and Ranger KMS with Oracle as the database > - verfied that plugins in HDFS/Hive/HBase/Kafka/YARN/KMS successfully > downloaded policies > > > Thanks, > > Madhan Neethiraj > >