----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75323/#review227142 -----------------------------------------------------------
ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java Line 50 (original), 48 (patched) <https://reviews.apache.org/r/75323/#comment315417> I suggest removing LOG.isDebugEnabled(), as this doesn't help with performance after use of parameterized messages. ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java Lines 166 (patched) <https://reviews.apache.org/r/75323/#comment315418> Replace string concat with use of parameterized log message: LOG.info("activeStateChangeHandlers(): before reorder: {}", activeStateChangeHandlers); Please review all LOG calls for similar updates. ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java Lines 40 (patched) <https://reviews.apache.org/r/75323/#comment315419> Separate static and non static members with a blank line. - Madhan Neethiraj On Dec. 21, 2024, 3:08 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75323/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2024, 3:08 a.m.) > > > Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Mehul > Parikh, and Pradeep Agrawal. > > > Bugs: RANGER-5055 > https://issues.apache.org/jira/browse/RANGER-5055 > > > Repository: ranger > > > Description > ------- > > Updated ranger-common-ha module to be compliant with checkstyle requirements > > > Diffs > ----- > > ranger-common-ha/pom.xml 994087238 > ranger-common-ha/src/main/java/org/apache/ranger/RangerHAInitializer.java > 56af81f54 > > ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java > 359fcbfff > > ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceState.java > 6a7a0e7b8 > > ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveStateChangeHandler.java > 50f696869 > ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java > fd18faaa1 > ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java > ded5a2ded > > ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java > 5be954e0e > ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java > e84a0e49d > > ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java > a38dd5183 > > ranger-common-ha/src/main/java/org/apache/ranger/ha/annotation/HAService.java > 9e84ef83c > > ranger-common-ha/src/main/java/org/apache/ranger/ha/service/HARangerService.java > a28766dfa > > ranger-common-ha/src/main/java/org/apache/ranger/ha/service/ServiceManager.java > fe7bd91f4 > > ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java > 516c07ba7 > > > Diff: https://reviews.apache.org/r/75323/diff/1/ > > > Testing > ------- > > Verified the build with unit tests complete successfully > > > Thanks, > > Dineshkumar Yadav > >
