kumaab commented on code in PR #505: URL: https://github.com/apache/ranger/pull/505#discussion_r1909934343
########## security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java: ########## @@ -2096,14 +1957,123 @@ RangerPolicy updatePolicyWithModifiedGrants(RangerPolicy policy, List<RangerGran return policy; } + private Long getOrCreateDataShare(Long datasetId, Long serviceId, Long zoneId, String serviceName) throws Exception { + LOG.debug("==> GdsREST.getOrCreateDataShare(dataSetId={} serviceId={} zoneId={} seviceName={})", datasetId); Review Comment: More params need to be passed in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org