----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75267/#review227169 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java Line 63 (original), 61 (patched) <https://reviews.apache.org/r/75267/#comment315425> can you please follow new code checkstyle and best patctice for readability. eg. LOG.warn("Service HTTP/HTTPS port is not configured correctly. Please configure properties {} and {}", (HAConfiguration.getPrefix(configuration) + HAConfiguration.RANGER_HA_SERVICE_HTTPS_PORT), (HAConfiguration.getPrefix(configuration) + HAConfiguration.RANGER_HA_SERVICE_HTTP_PORT)); - Dineshkumar Yadav On Jan. 13, 2025, 1:51 p.m., Rakesh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75267/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2025, 1:51 p.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Mehul > Parikh, Pradeep Agrawal, and sanket shelar. > > > Bugs: RANGER-4879 > https://issues.apache.org/jira/browse/RANGER-4879 > > > Repository: ranger > > > Description > ------- > > The following configs need to be updated in TAGSYNC / USERSYNC: > > update below tagsync configs in ranger-tagsync-site.xml > > ranger-ugsync.server.ha.http.port to ranger-ugsync.service.http.port > ranger-ugsync.server.ha.https.port to ranger-ugsync.service.https.port > update usersync configs in ranger-ugsync-site.xml > > ranger-tagsync.server.ha.http.port to ranger-tagsync.service.http.port > ranger-tagsync.server.ha.https.port to ranger-tagsync.service.https.port > > > Diffs > ----- > > > ranger-common-ha/src/main/java/org/apache/ranger/ha/ActiveInstanceElectorService.java > 213d7fb1a > ranger-common-ha/src/main/java/org/apache/ranger/ha/HAConfiguration.java > 425611ecd > > ranger-common-ha/src/main/java/org/apache/ranger/ha/RangerServiceServerIdSelector.java > 41335290d > ranger-common-ha/src/test/resources/ranger-tagsync-site.xml d37d7e43f > tagsync/src/main/resources/ranger-tagsync-site.xml 6bda5f4ab > > > Diff: https://reviews.apache.org/r/75267/diff/3/ > > > Testing > ------- > > Verified that the configuration values in ranger-ugsync-site.xml and > ranger-tagsync-site.xml were updated successfully. > > > Thanks, > > Rakesh Gupta > >
