----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75342/#review227181 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On Jan. 15, 2025, 7:29 p.m., Rakesh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75342/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2025, 7:29 p.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-5015 > https://issues.apache.org/jira/browse/RANGER-5015 > > > Repository: ranger > > > Description > ------- > > Best Practices for Safe and Optimized CSV and Excel Exports > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 8ea288a3b > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > fb1a72995 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > df2121483 > security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html > d16a24979 > > > Diff: https://reviews.apache.org/r/75342/diff/2/ > > > Testing > ------- > > Tested and verified that the "/plugins/policies/downloadExcel" and > "/plugins/policies/csv" APIs implement best practices for exporting CSV and > Excel files. > > > Thanks, > > Rakesh Gupta > >