----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75348/#review227208 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 692 (patched) <https://reviews.apache.org/r/75348/#comment315449> Add this api in ServiceREST also, check other similar implementations. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 696 (patched) <https://reviews.apache.org/r/75348/#comment315442> Remove this condition, check the new checkstyle rules mentioned by Abhishek security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 709 (patched) <https://reviews.apache.org/r/75348/#comment315443> same fix as above here as well security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4365 (patched) <https://reviews.apache.org/r/75348/#comment315448> move this method to ServiceDBStore security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4366 (patched) <https://reviews.apache.org/r/75348/#comment315444> remove condition as mentioned earlier. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4375 (patched) <https://reviews.apache.org/r/75348/#comment315445> add debug before return security-admin/src/main/resources/META-INF/jpa_named_queries.xml Lines 472 (patched) <https://reviews.apache.org/r/75348/#comment315446> fetch id only if not using whole object security-admin/src/main/resources/META-INF/jpa_named_queries.xml Lines 476 (patched) <https://reviews.apache.org/r/75348/#comment315447> fetch id only if not using whole object - Pradeep Agrawal On Jan. 25, 2025, 8:52 a.m., Guru Thejus Arveti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75348/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2025, 8:52 a.m.) > > > Review request for ranger and Pradeep Agrawal. > > > Repository: ranger > > > Description > ------- > > RANGER-5113: Added API to delete multiple policies using a wildcard > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > e8ea726cb > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 7b1eb7fe7 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f7c521111 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 855e27ae5 > > > Diff: https://reviews.apache.org/r/75348/diff/1/ > > > Testing > ------- > > Tested locally by firing the API from swagger and checking if policies are > getting deleted in ranger admin > > > Thanks, > > Guru Thejus Arveti > >
