> On March 19, 2025, 6:46 a.m., Pradeep Agrawal wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/CachedResourceEvaluators.java > > Line 76 (original), 76 (patched) > > <https://reviews.apache.org/r/75369/diff/3/?file=2297913#file2297913line76> > > > > if possible remove if condition as per the new recommended practice
The debug log contains a ternary computation, which will be evaluated every time regardless of whether debug logging is enabled. This is the reason I retined "if (LOG.isDebugEnabled())" check. let me know if you still want to remove it. - Dineshkumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75369/#review227295 ----------------------------------------------------------- On March 15, 2025, 4:49 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75369/ > ----------------------------------------------------------- > > (Updated March 15, 2025, 4:49 a.m.) > > > Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Mehul > Parikh, Pradeep Agrawal, Ramesh Mani, and Vyom Tiwari. > > > Bugs: RANGER-5162 > https://issues.apache.org/jira/browse/RANGER-5162 > > > Repository: ranger > > > Description > ------- > > Tag Allowed policy is not being enforced > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java > 920ddc716 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 246cc4514 > > agents-common/src/main/java/org/apache/ranger/plugin/util/CachedResourceEvaluators.java > 99cb0f858 > > > Diff: https://reviews.apache.org/r/75369/diff/3/ > > > Testing > ------- > > Testing done using ranger docker with help of tag.json > > > Thanks, > > Dineshkumar Yadav > >
