mneethiraj commented on PR #546: URL: https://github.com/apache/ranger/pull/546#issuecomment-2746947906
> The code changes look good to me. I noticed that all three script engine creators (Graal, JavaScript, and Nashorn) implement the ScriptEngineCreator interface. > > I was wondering if there's a specific reason for not implementing the 'getDefaultClassloader' method for all three ScriptEngineCreator implementations, instead relying on the default implementation for all three? I added the `default` method in the interface to avoid code duplication in all 3 implementations. Do you see any issues with using this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
