vyommani commented on code in PR #555:
URL: https://github.com/apache/ranger/pull/555#discussion_r2059570094
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -883,14 +883,11 @@ public RangerRoles getRangerRoles() {
}
public Set<RangerRole> getRangerRoleForPrincipal(String principal, String
type) {
- Set<RangerRole> ret = new HashSet<>();
- Set<RangerRole> rangerRoles = null;
+ Set<RangerRole> ret = new HashSet<>();
+ RangerPolicyEngine policyEngine = this.policyEngine;
Review Comment:
Do we need this change ?. I can see getRangerRole is already checking
policyEngine for null as follows
RangerPolicyEngine policyEngine = this.policyEngine;
if (policyEngine != null) {
return policyEngine.getRangerRoles();
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
