----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75377/#review227317 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java Lines 878 (patched) <https://reviews.apache.org/r/75377/#comment315560> `continue;` here would result in audit logs having no attributes to be excluded in the returned list. This doesn't seem right. Please review. Consider replacing #877 - #881 with the following: ``` List<AttributeChangeInfo> attrChanges = (objectChangeInfo == null || objectChangeInfo.getAttributes() == null) ? Collections.emptyList() : objectChangeInfo.getAttributes(); for (AttributeChangeInfo attrChangeInfo : attrChanges) { ``` security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java Lines 92 (patched) <https://reviews.apache.org/r/75377/#comment315561> `findActiveMappingsByDataShareId()` => `findDatasetsWithActiveDataShare()` security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java Lines 97 (patched) <https://reviews.apache.org/r/75377/#comment315562> `XXGdsDataset.findActiveMappingsByDataShareId` => `XXGdsDataset.findDatasetsWithDataShareInStatus` security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java Lines 97 (patched) <https://reviews.apache.org/r/75377/#comment315563> `XXGdsProject.findActiveMappingsByDatasetIds` => `XXGdsProject.findProjectsWithDatasetsInStatus` security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java Lines 173 (patched) <https://reviews.apache.org/r/75377/#comment315564> Replace all references to `obj` => `auditedObj`, since `obj` would be null for DELETE operations. security-admin/src/main/resources/META-INF/jpa_named_queries.xml Lines 2256 (patched) <https://reviews.apache.org/r/75377/#comment315565> This query return would include multiple instances of a project when multiple datasets in datasetIds are part of a project. Please review and update. - Madhan Neethiraj On May 8, 2025, 11:08 p.m., Radhika Kundam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75377/ > ----------------------------------------------------------- > > (Updated May 8, 2025, 11:08 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-5170 > https://issues.apache.org/jira/browse/RANGER-5170 > > > Repository: ranger > > > Description > ------- > > Improve Ranger logging to capture all hierarchical events for better > visibility and traceability. > > Currently, Ranger logs only direct changes to an entity, missing related > updates across interconnected entities. For example, when a resource is > created or updated, only a resource log is generated, making it difficult to > track associated changes in dependent entities. > > With this change, Ranger will generate logs for all impacted entities in the > hierarchy. Example: > > If a resource is modified, logs will be created for: > Resource > Datashare (if the resource is part of a datashare) > DataShareInDataset (if the datashare is linked to a dataset) > Dataset > > This transaction will log all the hierarchical logs and it'll include details > of the changed resource to ensure complete visibility. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java ec39448f3 > security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java > b0dbef3e8 > > security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetPolicyMapDao.java > b1ff36ad0 > security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java > a005519e7 > > security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectPolicyMapDao.java > b3529e840 > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java > d29e44eff > > security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java > edf514b1f > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 3559877d5 > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > 7bddf1874 > > > Diff: https://reviews.apache.org/r/75377/diff/4/ > > > Testing > ------- > > Tested locally.Attached example scenario of logs before and after the change. > > > File Attachments > ---------------- > > Example Logs with updated patch > > https://reviews.apache.org/media/uploaded/files/2025/05/08/26a51489-1f07-4639-8ff2-4edd4d1dbba6__Examples_previous_vs_current_logging.png > > > Thanks, > > Radhika Kundam > >
