----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75389/#review227321 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java Line 213 (original), 220 (patched) <https://reviews.apache.org/r/75389/#comment315568> `extractPartialLabelKeywordFilters(filter)` returning a boolean value is not intutive. Instead of this approach, I suggest the following: 1. Use following query parameters: - datasetLabel (multi-valued) - datasetLabelMatchType (full or partial) - datasetKeyword (multi-valued) - datasetKeywordMatchType (full or partial) 2. Use PARTIAL match in SearchField objects for labels and keywords ``` searchFields.add(new SearchField(SearchFilter.DATASET_LABEL, "obj.labels", SearchField.DATA_TYPE.STRING, SearchField.SEARCH_TYPE.PARTIAL)); searchFields.add(new SearchField(SearchFilter.DATASET_KEYWORD, "obj.keywords", SearchField.DATA_TYPE.STRING, SearchField.SEARCH_TYPE.PARTIAL)); ``` 3. In case of 'matchType=full', do post-processing of the results. When multiple values are provided for query parameter datasetLabel or datasetKeyword, the search only looks for at least one value to be present in a dataset (and not all values) - right? - Madhan Neethiraj On May 20, 2025, 9:03 p.m., Radhika Kundam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75389/ > ----------------------------------------------------------- > > (Updated May 20, 2025, 9:03 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-5213 > https://issues.apache.org/jira/browse/RANGER-5213 > > > Repository: ranger > > > Description > ------- > > Dataset Search and Summary APIs should support filtering by isEnabled and > Partila/Exact text search for Labels and Keywords. > QueryParams to use for, > Partial Search: > datasetLabelPartial > datasetKeywordPartial > Full Search: > datasetLabel > datasetKeyword > isEnabled Filter: > A new query parameter to include/exclude datasets based on their enabled > status. > Example: isEnabled=true returns only enabled datasets. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 717b94c67 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > a76c2b5a3 > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 84009c3fa > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > 8ace32a53 > > > Diff: https://reviews.apache.org/r/75389/diff/1/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Radhika Kundam > >
