fateh288 commented on code in PR #569: URL: https://github.com/apache/ranger/pull/569#discussion_r2194003420
########## liquibase-database-upgrade/src/main/java/org/apache/ranger/db/upgrade/LiquibaseCommandResultsUtil.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ranger.db.upgrade; + +import liquibase.command.CommandResults; +import liquibase.report.OperationInfo; +import liquibase.report.UpdateReportParameters; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LiquibaseCommandResultsUtil { + private static final Logger LOG = LoggerFactory.getLogger(LiquibaseCommandResultsUtil.class); + + private LiquibaseCommandResultsUtil() { + } + + public static boolean doesTagExist(CommandResults tagExistsResult) { + boolean res = (Boolean) tagExistsResult.getResult("tagExistsResult"); + LOG.info("doesTagExist({})={}", tagExistsResult, res); + return res; + } + + public static boolean isUpdateSuccessful(CommandResults updateResult) { + /* + TODO: revisit this + */ + boolean operationInfoResult = updateResult.getResult("operationInfo") != null && Review Comment: @dhavalshah9131 If updateResult is indeed null somehow, I think it is ok that an exception is thrown. I did give it a thought on whether we should return true or false by default if updateResult is null but it can go either ways and a wrong return value can result in incorrect logic being applied in the next steps which we dont want. If there is a more elegant way to handle such scenarios I will be happy to incorporate the same. Let me know your suggestions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
