kumaab commented on code in PR #719:
URL: https://github.com/apache/ranger/pull/719#discussion_r2467414064
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
Review Comment:
This may be removed as well.
##########
dev-support/ranger-docker/scripts/access-control.properties:
##########
@@ -0,0 +1,4 @@
+access-control.name=ranger
+
+ranger.service.name=dev_trino
+ranger.plugin.config.resource=/etc/trino/ranger-trino-security.xml,/etc/trino/ranger-trino-audit.xml
Review Comment:
I understand SSL is not enabled in docker yet but can
`ranger-policymgr-ssl.xml` be added here as well? Once the support is added,
the values would need to updated in that case.
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
-ENV PLUGIN_DIR=ranger-${TRINO_PLUGIN_VERSION}-trino-plugin
-RUN mkdir -p /home/ranger/dist /home/ranger/scripts /opt/ranger
+RUN mkdir -p /home/ranger/scripts/
-COPY ./dist/version
/home/ranger/dist
-COPY ./dist/ranger-${TRINO_PLUGIN_VERSION}-trino-plugin.tar.gz
/home/ranger/dist
-COPY ./scripts/ranger-trino.sh
/home/ranger/scripts
-COPY ./scripts/ranger-trino-setup.sh
/home/ranger/scripts
-COPY ./scripts/ranger-trino-plugin-install.properties
/home/ranger/scripts
+COPY ./scripts/access-control.properties /etc/trino/
Review Comment:
How about keeping all config files in a `dir` named `trino` inside `scripts`
or `configs` and just using
COPY ./configs/trino/* /path/in/trino/container here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
