mneethiraj commented on code in PR #724:
URL: https://github.com/apache/ranger/pull/724#discussion_r2496801664
##########
ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java:
##########
@@ -98,7 +97,7 @@ public String getLdapBindDn() {
String val = prop.getProperty(LGSYNC_LDAP_BIND_DN);
if (val == null || val.trim().isEmpty()) {
- throw new NullArgumentException(LGSYNC_LDAP_BIND_DN);
+ throw new IllegalArgumentException(LGSYNC_LDAP_BIND_DN + "
must not be null or empty");
Review Comment:
Can you review following checkstyle failures and address them please? Make
sure to run "mvn clean verify" in your local environment to detect such issues.
```
[ERROR] src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java:[1]
(misc) NewlineAtEndOfFile: File does not end with a newline.
[ERROR]
src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java:[100]
(indentation) Indentation: 'if' child has incorrect indentation level 17,
expected level should be 12.
[ERROR]
src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java:[100,9]
(whitespace) FileTabCharacter: File contains tab characters (this is the first
instance).
```
##########
ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfigCheckMain.java:
##########
@@ -19,7 +19,6 @@
package org.apache.ranger.ldapconfigcheck;
-import org.apache.commons.lang.NullArgumentException;
Review Comment:
Can you review following checkstyle failures and address them please? Make
sure to run "mvn clean verify" in your local environment to detect such issues.
```
[ERROR]
src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfigCheckMain.java:[20]
(regexp) RegexpMultiline: Multiple consecutive blank lines
[ERROR]
src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfigCheckMain.java:[161]
(indentation) Indentation: 'if' child has incorrect indentation level 16,
expected level should be 12.
[ERROR]
src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfigCheckMain.java:[161,9]
(whitespace) FileTabCharacter: File contains tab characters (this is the first
instance).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
