mneethiraj commented on code in PR #729:
URL: https://github.com/apache/ranger/pull/729#discussion_r2511111894


##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -98,7 +98,7 @@ public class RangerBasePlugin {
     private final List<RangerChainedPlugin>   chainedPlugins;
     private final boolean                     dedupStrings;
     private       PolicyRefresher             refresher;
-    private       RangerPolicyEngine          policyEngine;
+    private volatile RangerPolicyEngine       policyEngine;
     private       RangerAuthContext           currentAuthContext;

Review Comment:
   @vyommani  - can you please review if following fields also need to be 
marked as `volatile`?
   - currentAuthContext
   - roles
   - serviceConfigs
   
   These fields are updated whenever the plugin receives new policies or roles 
or tags; and are referenced from multiple threads.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to