[
https://issues.apache.org/jira/browse/RANGER-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048712#comment-18048712
]
Dhaval Shah commented on RANGER-5411:
-------------------------------------
Merged into apache Master :
[https://github.com/apache/ranger/commit/cde5be80c8cc1394cfe22284ce7065b6ac75def5]
Thanks
> Refactor logic to use external Key as MasterKey to avoid code redundancy
> ------------------------------------------------------------------------
>
> Key: RANGER-5411
> URL: https://issues.apache.org/jira/browse/RANGER-5411
> Project: Ranger
> Issue Type: Task
> Components: kms
> Reporter: Vikas Kumar
> Assignee: Vikas Kumar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Current behaviour:*
> To import key from LunaHSM or KeySecure, there are two methods (
> generateMKFromHSMMK and generateMKFromKeySecureMK ) in the RangerMasterKey
> class, doing exactly the same thing.
> *Expected behaviour:*
> Super type, RangerKMSMKI should introduce a new aspect to import external
> cryptographic key as MasterKey. Hence, it should have one method and other
> implementations should override that.
> Default implementation should throw UnsupportedOperationException.
> This will help reuse the code , improve code maintenance and code can written
> on super-type instead of specific class object.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
