Copilot commented on code in PR #787:
URL: https://github.com/apache/ranger/pull/787#discussion_r2660033660
##########
dev-support/ranger-docker/scripts/wait_for_testusers_keytab.sh:
##########
@@ -0,0 +1,21 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
Review Comment:
The shebang line appears to have leading whitespace before '#!/bin/bash'.
The shebang must be at the very beginning of the file (column 1) to be properly
recognized by the system. Remove any leading spaces or tabs before the shebang.
```suggestion
or more contributor license agreements. See the NOTICE file
```
##########
dev-support/ranger-docker/Dockerfile.ranger-tagsync:
##########
@@ -23,6 +23,7 @@ ARG TAGSYNC_VERSION
COPY ./dist/ranger-${TAGSYNC_VERSION}-tagsync.tar.gz /home/ranger/dist/
COPY ./scripts/tagsync/ranger-tagsync.sh ${RANGER_SCRIPTS}/
COPY ./scripts/wait_for_keytab.sh ${RANGER_SCRIPTS}/
+COPY ./scripts/wait_for_testusers_keytab.sh ${RANGER_SCRIPTS}/
Review Comment:
The Dockerfile.ranger-tagsync references ranger-tagsync-install.properties
on line 33, but there is no COPY command to copy this file from the build
context into the Docker image. The file should be copied before it can be used
in the RUN command. Add a COPY command similar to:
COPY ./scripts/tagsync/ranger-tagsync-install.properties ${RANGER_SCRIPTS}/
```suggestion
COPY ./scripts/wait_for_testusers_keytab.sh ${RANGER_SCRIPTS}/
COPY ./scripts/tagsync/ranger-tagsync-install.properties ${RANGER_SCRIPTS}/
COPY ./scripts/tagsync/ranger-tagsync-tags.json ${RANGER_SCRIPTS}/
```
##########
dev-support/ranger-docker/Dockerfile.ranger-tagsync:
##########
@@ -23,6 +23,7 @@ ARG TAGSYNC_VERSION
COPY ./dist/ranger-${TAGSYNC_VERSION}-tagsync.tar.gz /home/ranger/dist/
COPY ./scripts/tagsync/ranger-tagsync.sh ${RANGER_SCRIPTS}/
COPY ./scripts/wait_for_keytab.sh ${RANGER_SCRIPTS}/
+COPY ./scripts/wait_for_testusers_keytab.sh ${RANGER_SCRIPTS}/
Review Comment:
The Dockerfile.ranger-tagsync references ranger-tagsync-tags.json on line
34, but there is no COPY command to copy this file from the build context into
the Docker image. The file should be copied before it can be used in the RUN
command. Add a COPY command similar to:
COPY ./scripts/tagsync/ranger-tagsync-tags.json ${RANGER_SCRIPTS}/
```suggestion
COPY ./scripts/wait_for_testusers_keytab.sh ${RANGER_SCRIPTS}/
COPY ./scripts/tagsync/ranger-tagsync-tags.json ${RANGER_SCRIPTS}/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
