Copilot commented on code in PR #696:
URL: https://github.com/apache/ranger/pull/696#discussion_r2670520282
##########
authz-embedded/src/test/resources/test_hive/README.txt:
##########
@@ -0,0 +1,26 @@
+1. Test Setup
+ 1. database=mydb, table=tbl1, column=*
+ user=tbl1-r-user, permission=select
+ user=tbl1-rw-user, permission=select,update
+ 2. database=mydb, table=tbl2, column=*
+ user=tbl2-r-user, permission=select
+ user=tbl2-rw-user, permission=select,update
+ 3. database=mydb, table=*, column=*
+ user=all-tbl-r-user, permission=select
+ 4. database=mydb, table=tbl_tag1, column=*
+ tag=TAG1
+ user=tag1-r-user, permission=select
+ user=tag1-rw-user, permission=select,update
+ 5. database=mydb, table=tbl_tag2, column=*
+ tag=TAG2
+ user=tag2-r-user, permission=select
+ user=tag2-rw-user, permission=select,update
+ 6. database=mydb, table=tbl_ds1, column=*
+ dataset=ds1
+ user=ds1-r-user, permission=select
+ 6. database=mydb, table=tbl_ds2, column=*
+ dataset=ds2
+ user=ds2-r-user, permission=select
+ 7. database=mydb, table=tbl_ds3, column=col1,col2,col3
Review Comment:
Duplicate numbering: both items 6 and 7 are numbered as '6'. The second item
should be numbered '7'.
```suggestion
7. database=mydb, table=tbl_ds2, column=*
dataset=ds2
user=ds2-r-user, permission=select
8. database=mydb, table=tbl_ds3, column=col1,col2,col3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
