mneethiraj commented on code in PR #7:
URL: https://github.com/apache/ranger-tools/pull/7#discussion_r2719711913
##########
docker/Dockerfile:
##########
@@ -56,6 +56,15 @@ COPY docker/create_users_and_groups.sh ${RANGER_SCRIPTS}
RUN chmod +x /home/ranger/scripts/create_users_and_groups.sh && \
./home/ranger/scripts/create_users_and_groups.sh
Review Comment:
- "./home/ranger/" => "/home/scripts" ? The current version works because
the command is run from root directory ("/")?
- consider following replacements in lines 51 to 57:
- "/home/ranger/scripts" with "${RANGER_SCRIPTS}"
- "/home/ranger/dist" with "${RANGER_DIST}"
- "/opt/ranger" with "${RANGER_HOME}"
- consider updating create_users_and_groups.sh to create test users as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
