rameeshm commented on code in PR #847:
URL: https://github.com/apache/ranger/pull/847#discussion_r2851279974
##########
ranger-audit-server/ranger-audit-server-service/src/main/java/org/apache/ranger/audit/rest/AuditREST.java:
##########
@@ -155,7 +155,7 @@ public Response getStatus() {
@Path("/access")
@Consumes("application/json")
@Produces("application/json")
- public Response accessAudit(@QueryParam("serviceName") String serviceName,
List<AuthzAuditEvent> accessAudits, @Context HttpServletRequest request) {
+ public Response logAccessAudit(@QueryParam("serviceName") String
serviceName, List<AuthzAuditEvent> accessAudits, @Context HttpServletRequest
request) {
Review Comment:
@rameeshm we should also have batch Id (App Id) for the batch of audits
send, so that kafka can process this in batch and commit for better performance.
##########
ranger-audit-server/ranger-audit-server-service/src/main/java/org/apache/ranger/audit/rest/AuditREST.java:
##########
@@ -155,7 +155,7 @@ public Response getStatus() {
@Path("/access")
@Consumes("application/json")
@Produces("application/json")
- public Response accessAudit(@QueryParam("serviceName") String serviceName,
List<AuthzAuditEvent> accessAudits, @Context HttpServletRequest request) {
+ public Response logAccessAudit(@QueryParam("serviceName") String
serviceName, List<AuthzAuditEvent> accessAudits, @Context HttpServletRequest
request) {
Review Comment:
Improvement on the audit batching done with latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
