mneethiraj commented on code in PR #873: URL: https://github.com/apache/ranger/pull/873#discussion_r2927417027
########## security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerHeaderPreAuthFilter.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.ranger.security.web.filter; + +import org.apache.commons.lang3.StringUtils; +import org.apache.ranger.biz.UserMgr; +import org.apache.ranger.common.PropertiesUtil; +import org.apache.ranger.entity.XXPortalUser; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.security.authentication.UsernamePasswordAuthenticationToken; +import org.springframework.security.core.GrantedAuthority; +import org.springframework.security.core.authority.SimpleGrantedAuthority; +import org.springframework.security.core.context.SecurityContextHolder; +import org.springframework.security.core.userdetails.User; +import org.springframework.security.core.userdetails.UserDetails; +import org.springframework.security.web.authentication.WebAuthenticationDetails; +import org.springframework.web.filter.GenericFilterBean; + +import javax.servlet.FilterChain; +import javax.servlet.ServletException; +import javax.servlet.ServletRequest; +import javax.servlet.ServletResponse; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; + +public class RangerHeaderPreAuthFilter extends GenericFilterBean { + private static final Logger LOG = LoggerFactory.getLogger(RangerHeaderPreAuthFilter.class); + + public static final String PROP_HEADER_AUTH_ENABLED = "ranger.authn.header.enabled"; + public static final String PROP_USERNAME_HEADER_NAME = "ranger.authn.header.username"; + public static final String PROP_REQUEST_ID_HEADER_NAME = "ranger.authn.header.requestid"; + public static final String DEFAULT_USERNAME_HEADER_NAME = "x-awc-username"; + public static final String DEFAULT_REQUEST_ID_HEADER_NAME = "x-awc-requestid"; + + @Autowired + UserMgr userMgr; + + @Override + public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { + HttpServletRequest httpRequest = (HttpServletRequest) request; + + if (!PropertiesUtil.getBooleanProperty(PROP_HEADER_AUTH_ENABLED, false)) { Review Comment: Consider caching this value in `@Override public void init(FilterConfig filterConfig)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
