vyommani commented on code in PR #874:
URL: https://github.com/apache/ranger/pull/874#discussion_r2934842110
##########
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java:
##########
@@ -168,7 +172,7 @@ public ServicePolicies getServicePoliciesIfUpdated(final
long lastKnownVersion,
checkAndResetSessionCookie(response);
- if (response == null || response.getStatus() ==
HttpServletResponse.SC_NOT_MODIFIED || response.getStatus() ==
HttpServletResponse.SC_NO_CONTENT) {
+ if (response == null || response.getStatus() == SC_NOT_MODIFIED ||
response.getStatus() == SC_NO_CONTENT) {
Review Comment:
This is mostly a matter of preference, but I think importing the HttpStatus
class and using HttpStatus.SC_NO_CONTENT (instead of a static import) would
make the code more readable and self-documenting for future readers/maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
