kumaab commented on code in PR #872:
URL: https://github.com/apache/ranger/pull/872#discussion_r3067165047
##########
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java:
##########
@@ -81,71 +82,63 @@ public class PolicyMgrUserGroupBuilder extends
AbstractUserGroupSource implement
/* ******************* */
private static final String AUTHENTICATION_TYPE =
"hadoop.security.authentication";
- private static final String AUTH_KERBEROS =
"kerberos";
private static final String KERBEROS_PRINCIPAL =
"ranger.usersync.kerberos.principal";
private static final String KERBEROS_KEYTAB =
"ranger.usersync.kerberos.keytab";
private static final String NAME_RULE =
"hadoop.security.auth_to_local";
- private static final String SOURCE_EXTERNAL = "1";
- private static final String STATUS_ENABLED = "1";
- private static final String ISVISIBLE = "1";
- private static final String ISHIDDEN = "0";
private static final Pattern USER_OR_GROUP_NAME_VALIDATION_REGEX =
Pattern.compile("^([A-Za-z0-9_]|[\u00C0-\u017F])([a-zA-Z0-9\\s,._\\-+/@=
]|[\u00C0-\u017F])+$", Pattern.CASE_INSENSITIVE);
- private static final String ERR_MSG_FOR_INACTIVE_SERVER = "This
userGroupSync server is not in active state. Cannot commit transaction!";
-
- private static String localHostname;
Review Comment:
L95-L138, refactoring has been done in
https://github.com/apache/ranger/commit/426f2a0c507aa25cc8888c61a7723e56d1f6a26c
to ensure the variable return types are grouped together for better
readability, please keep this order.
##########
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java:
##########
@@ -1024,13 +1023,7 @@ public ServiceGdsInfo getGdsInfoIfUpdated(long
lastKnownVersion, long lastActiva
@Override
public boolean isAuthenticationEnabled() {
- return (restClient != null && restClient.isAuthFilterPresent()) ||
super.isAuthenticationEnabled();
- }
-
- public void setJwtProvider(JwtProvider jwtProvider) {
Review Comment:
this is a recently added function, why is it being removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
