kumaab commented on code in PR #886: URL: https://github.com/apache/ranger/pull/886#discussion_r3229853447
########## dev-support/ranger-docker/Dockerfile.ranger-audit-dispatcher: ########## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +ARG RANGER_BASE_IMAGE +ARG RANGER_BASE_VERSION +FROM ${RANGER_BASE_IMAGE}:${RANGER_BASE_VERSION} + +# Declare ARG for use in this build stage +ARG RANGER_VERSION +ARG KERBEROS_ENABLED + +# Install required packages including Kerberos client +RUN apt-get update && apt-get install -y \ Review Comment: All of these packages (except `net-tools`) are already present in the base image: https://github.com/apache/ranger-tools/blob/main/docker/Dockerfile, this can be safely removed. ########## dev-support/ranger-docker/docker-compose.ranger-audit-ingestor.yml: ########## @@ -0,0 +1,246 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +services: + # Audit Ingestor Service - Receives audits from plugins and produces to Kafka (REFACTORED) + ranger-audit-ingestor: Review Comment: `ranger-audit-ingestor` service is duplicated in this file, not sure what is the reason for doing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
