rameeshm commented on code in PR #965:
URL: https://github.com/apache/ranger/pull/965#discussion_r3289306555
##########
dev-support/ranger-docker/scripts/solr/solr-ranger_audits/solrconfig.xml:
##########
@@ -417,7 +417,7 @@
to occupy. Note that when this option is specified, the
size
and initialSize parameters are ignored.
-->
- <filterCache class="solr.FastLRUCache"
+ <filterCache class="solr.CaffeineCache"
Review Comment:
How is the upgrade going to be handled?
##########
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java:
##########
@@ -31,7 +31,7 @@
public class RangerSolrAuditHandler extends RangerMultiResourceAuditHandler {
private static final String PROP_SOLR_PLUGIN_AUDIT_EXCLUDED_USERS =
"ranger.solr.plugin.audit.excluded.users";
- private static final String RANGER_AUDIT_COLLECTION =
"ranger_audits";
+ public static final String RANGER_AUDIT_COLLECTION =
"ranger_audits";
Review Comment:
Please check the code style on this patch. Many misaligned lines are there
like this one
##########
ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java:
##########
@@ -40,6 +40,23 @@
public class RangerPluginClassLoader extends URLClassLoader {
Review Comment:
@pradeepagrawal8184 This is bit invasive in doing. If the Jersey libraries
are already present in the SOLR can we remove it from the SOLR?
##########
dev-support/ranger-docker/scripts/hadoop/ranger-hadoop-setup.sh:
##########
@@ -66,6 +66,10 @@ else
echo "WARNING: Tez directory not found at /opt/tez"
fi
+mkdir -p /etc/ranger/dev_hdfs/policycache /etc/ranger/dev_yarn/policycache
Review Comment:
Is this change related to Solr upgrade?
##########
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java:
##########
@@ -685,6 +710,36 @@ private RangerAccessRequestImpl createBaseRequest(String
userName, Set<String> u
return rangerRequest;
}
+ /**
Review Comment:
Pluing service user normally authenticates into SOLR to commit into
ranger_audits. We have policies for it, so wondering what is the purpose this
method. Please check it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
