Copilot commented on code in PR #999:
URL: https://github.com/apache/ranger/pull/999#discussion_r3367879042
##########
distro/pom.xml:
##########
@@ -77,6 +77,12 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.ranger</groupId>
+ <artifactId>ranger-audit-dest-auditserver</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
This PR’s stated goal is to make audit-server the only audit destination in
the packaged artifacts, but `distro/pom.xml` still declares other audit
destination dependencies (e.g., `ranger-audit-dest-cloudwatch`,
`ranger-audit-dest-es`, `ranger-audit-dest-hdfs`, `ranger-audit-dest-kafka`,
`ranger-audit-dest-log4j`, `ranger-audit-dest-solr`) later in the same
dependencies section. If those destinations are no longer supported/packaged,
consider removing the remaining destination dependencies (and any related
dispatcher dependencies) from this POM as well; otherwise, please align the PR
title/description to clarify that only the *plugin assemblies* were changed,
not the distro module’s declared destinations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
