fmorg-git commented on code in PR #1073:
URL: https://github.com/apache/ranger/pull/1073#discussion_r3597375869


##########
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java:
##########
@@ -101,4 +109,52 @@ protected RangerServiceDef 
mapEntityToViewBean(RangerServiceDef vObj, XXServiceD
 
         return ret;
     }
+
+    @Override
+    protected RangerServiceDef populateViewBean(XXServiceDef xServiceDef) {
+        final RangerServiceDef ret = super.populateViewBean(xServiceDef);
+
+        applyOzoneActionPolicyHiddenOption(ret);
+
+        return ret;
+    }
+
+    void applyOzoneActionPolicyHiddenOption(RangerServiceDef serviceDef) {
+        if (serviceDef == null) {
+            return;
+        }
+
+        Map<String, String> serviceDefOptions = serviceDef.getOptions();
+
+        if (serviceDefOptions == null) {
+            serviceDefOptions = new HashMap<>();
+            serviceDef.setOptions(serviceDefOptions);
+        }
+
+        if (serviceDefOptions.get(OPTION_ENABLE_OZONE_ACTION_POLICY) == null) {
+            boolean enableOzoneActionPolicy = 
config.getBoolean(PROP_ENABLE_OZONE_ACTION_POLICY, false);
+
+            serviceDefOptions.put(OPTION_ENABLE_OZONE_ACTION_POLICY, 
Boolean.toString(enableOzoneActionPolicy));
+            serviceDef.setOptions(serviceDefOptions);

Review Comment:
   hi all - just for my understanding - if enableOzoneActionPolicy is added to 
all serviceDef and they don't support RangerActionMatcher, does it affect any 
behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to