fimugdha commented on code in PR #1073:
URL: https://github.com/apache/ranger/pull/1073#discussion_r3600910716
##########
security-admin/src/main/java/org/apache/ranger/patch/PatchForOzoneServiceDefPolicyConditionUpdate_J10065.java:
##########
@@ -18,6 +18,7 @@
package org.apache.ranger.patch;
Review Comment:
@ramackri,
All the serviceDefs currently in Ranger have
`enableDenyAndExceptionsInPolicies` & `enableTagBasedPolicies` options.
The updated fix in the pull-request file > RangerServiceDefService.java for
ozone-sts feature flag is doing two things :
1st - setting `enableActionMatcherInPoliciesCondition` now as false for all
the serviceDef except for ozone it is setting the value for this option
depending upon the xml config :
`ranger.servicedef.ozone.enableActionMatcherInPoliciesCondition`.
2nd - Add the actionMatcher policyCondtion only to ozone serviceDef
depending upon the xml config.
The J10065 java patch should add this option
`enableActionMatcherInPoliciesCondition` to false for all the serviceDefs
except for ozone. For ozone, it will be checking the boolean from the xml
config for this option.
This J10065 java patch should not update touch the existing options :
`enableDenyAndExceptionsInPolicies` and `enableTagBasedPolicies` for any
serviceDefs (including ozone).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
