kumaab commented on code in PR #1058:
URL: https://github.com/apache/ranger/pull/1058#discussion_r3798964655
##########
dev-support/ranger-docker/README.md:
##########
Review Comment:
I'm trying to understand why do we need hadoop container here? Opensearch
requires kafka and audit server only right ?
##########
dev-support/ranger-docker/README.md:
##########
@@ -202,23 +205,22 @@ docker compose -f docker-compose.ranger.yml -f
docker-compose.ranger-opensearch.
-f docker-compose.ranger-audit-dispatcher-opensearch.yml up -d
ranger-audit-ingestor ranger-audit-dispatcher-opensearch
~~~
-To use OpenSearch with **mysql or oracle** instead, enable the OpenSearch
block in the matching
-`scripts/admin/ranger-admin-install-${RANGER_DB_TYPE}.properties` (uncomment
the `audit_store=opensearch`
-and `audit_opensearch_*` lines and comment out the Solr block) before running
the setup commands.
+To use OpenSearch with **any DB type**, simply set `export
RANGER_AUDIT_STORE=opensearch` before
+bringing up the stack — no manual `install.properties` edits required.
-For **existing Solr-based installs**, switch stores by setting
`audit_store=opensearch` (and the
-`audit_opensearch_*` properties) in install.properties and restarting Ranger
Admin.
+For **existing Solr-based installs**, set `RANGER_AUDIT_STORE=opensearch`,
recreate the Ranger
Review Comment:
typo: `RANGER_AUDIT_STORE=opensearch` ==> `RANGER_AUDIT_STORE=solr`
##########
dev-support/ranger-docker/README.md:
##########
Review Comment:
Suggestion: `(replace Solr for access audits)` may be removed.
##########
dev-support/ranger-docker/README.md:
##########
@@ -80,8 +80,11 @@ cd dev-support/ranger-docker
# export ENABLE_FILE_SYNC_SOURCE=true
# valid values for RANGER_DB_TYPE: mysql/postgres/oracle
+# valid values for RANGER_AUDIT_STORE: opensearch (default) | solr
+# The core stack brings up the audit backend for the default store
(OpenSearch).
+# For Solr: export RANGER_AUDIT_STORE=solr and replace -f
docker-compose.ranger-opensearch.yml with -f docker-compose.ranger-solr.yml
below.
-docker compose -f docker-compose.ranger.yml -f docker-compose.ranger-solr.yml
-f docker-compose.ranger-usersync.yml -f docker-compose.ranger-tagsync.yml -f
docker-compose.ranger-pdp.yml -f docker-compose.ranger-kms.yml up -d
+docker compose -f docker-compose.ranger.yml -f
docker-compose.ranger-opensearch.yml -f docker-compose.ranger-usersync.yml -f
docker-compose.ranger-tagsync.yml -f docker-compose.ranger-pdp.yml -f
docker-compose.ranger-kms.yml up -d
Review Comment:
`ranger-opensearch` ==> `ranger-${RANGER_AUDIT_STORE}`
Please update other references as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
