dhavaljrajpara opened a new pull request, #1170:
URL: https://github.com/apache/ranger/pull/1170
## What changes were proposed in this pull request?
**Issue Summary**
Duplicate service configurations (Superusers/Service Admin) in Trino service
definition.
**Problem Description**
In the Trino service definition, duplicate entries are currently appearing
for the following service configuration options on the UI:
* Superusers ({{ranger.plugin.trino.superusers}})
* Superuser groups ({{ranger.plugin.trino.superuser.groups}})
* Service admin users ({{ranger.plugin.trino.service.admin.users}})
* Service admin usergroups
({{ranger.plugin.trino.service.admin.user.groups}})
**Root Cause**
The Trino service definition JSON already contains these management
properties explicitly. However, following *RANGER-3643*, these properties were
also added dynamically on the frontend across all service definitions. As a
result, Trino inherits both sets of definitions, rendering duplicate inputs in
the service creation/edit UI.
Due to this duplication, submitting the service configuration form
constructs a malformed JSON payload, resulting in invalid/incorrect values
being stored in the database and causing service creation to fail.
**Expected Behavior**
# The Trino service configuration page should render only a single instance
for each administrative property.
# Creating or updating a Trino service should pass valid configuration
values and persist properly to the database.
## How was this patch tested?
1. Built and restarted Ranger Admin with the updated Trino service
definition.
2. Verified on the UI that Trino service creation/edit forms render
`Superusers`, `Superuser groups`, `Service admin users`, and `Service admin
usergroups` only once.
3. Created and updated a Trino service instance and verified that the
backend receives valid configuration payloads and persists correct values in
the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
